"Did you bring an umbrella with you?"
Yes, you are correct. 有 best translates to "to have" than "to bring".
It makes it clearly past tense -- meaning you brought the umbrella and you still have it with you. Without it, the sentence is not clearly past tense, but I'm not sure that's strictly necessary for the translation.